From e5c3f71503a29e138afa45ebf271c748d3a3280b Mon Sep 17 00:00:00 2001 From: Brian Wolff Date: Wed, 18 Oct 2017 05:28:43 +0000 Subject: [PATCH] SECURITY: Escape internal error message This message contains the request url, which is semi-user controlled. Most browsers percent escape < and > so its probably not exploitable (curl is an exception here), but nonetheless its not good. Bug: T178451 Change-Id: I19358471ddf1b28377aad8e0fb54797c817bb6f6 --- RELEASE-NOTES-1.28 | 2 ++ includes/exception/MWException.php | 16 +++++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/RELEASE-NOTES-1.28 b/RELEASE-NOTES-1.28 index b916d23768..870f9c33ab 100644 --- a/RELEASE-NOTES-1.28 +++ b/RELEASE-NOTES-1.28 @@ -17,6 +17,8 @@ This is not a release yet! * (T160298) Remove use of implicitGroupBy() in ActiveUsersPager. * (T174255) Declare uploadCount property in importDump.php. * Updated dev dependancy phpunit/phpunit from v4.8.24 to v4.8.36. +* (T178451) SECURITY: Potential XSS when $wgShowExceptionDetails = false and browser + sends non-standard url escaping. == MediaWiki 1.28.1 == diff --git a/includes/exception/MWException.php b/includes/exception/MWException.php index e958c9449f..93952c9795 100644 --- a/includes/exception/MWException.php +++ b/includes/exception/MWException.php @@ -114,13 +114,15 @@ class MWException extends Exception { $logId = WebRequest::getRequestId(); $type = get_class( $this ); return "
" . - '[' . $logId . '] ' . - gmdate( 'Y-m-d H:i:s' ) . ": " . - $this->msg( "internalerror-fatal-exception", - "Fatal exception of type $1", - $type, - $logId, - MWExceptionHandler::getURL( $this ) + htmlspecialchars( + '[' . $logId . '] ' . + gmdate( 'Y-m-d H:i:s' ) . ": " . + $this->msg( "internalerror-fatal-exception", + "Fatal exception of type $1", + $type, + $logId, + MWExceptionHandler::getURL( $this ) + ) ) . "
\n" . "